Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add isPlainObject #133

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

feat: add isPlainObject #133

wants to merge 18 commits into from

Conversation

ignoreintuition
Copy link
Contributor

No description provided.

DerekNonGeneric
DerekNonGeneric reviewed Oct 15, 2022
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
DerekNonGeneric
DerekNonGeneric reviewed Oct 15, 2022
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
@DerekNonGeneric DerekNonGeneric changed the title added isPlainObject feat: add isPlainObject Oct 15, 2022
DerekNonGeneric
DerekNonGeneric reviewed Oct 16, 2022
View reviewed changes
Copy link
Member

@DerekNonGeneric DerekNonGeneric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although nearly all of these additional changes made in c1aa265 are desirable, they do fall outside the scope of this PR (which is to handle the addition of a new helper function).

I am thinking that we can propose your changes from that commit as being made in a separate PR so that we can continue the discussion relating to isPlainObject here…

Let me see about moving that commit over into another PR.

@DerekNonGeneric DerekNonGeneric mentioned this pull request Oct 16, 2022
Merged
DerekNonGeneric and others added 3 commits October 16, 2022 22:30
@DerekNonGeneric
style(eslint): apply specified code style changes (OpenINF#138)
34fdb2a 
Refs: https://babeljs.io/docs/en/assumptions#setspreadproperties

Fixes: OpenINF#141
Fixes: OpenINF#139

Co-authored-by: Brian Greig <brian@resurgencewebdesign.com>
Co-authored-by: septs <github@septs.pw>

Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is>
@deepsource-autofix
style(auto): format all supported code with prettier (OpenINF#143)
4a21a46 
This commit fixes the style issues introduced in 34fdb2a according to the output
from prettier.

Details: https://deepsource.io/gh/openinf/util-object/transform/cbebf681-0853-4c36-8d29-c8d47d0f641f/

Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
@DerekNonGeneric
fix(auto): add blank line after commit msg subject
f8fd561 
Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is>
@DerekNonGeneric DerekNonGeneric added the wip Issues and PRs that are still a work in progress label Oct 18, 2022
DerekNonGeneric and others added 5 commits October 17, 2022 22:21
@DerekNonGeneric
fix(deps): rm jsdoc-to-markdown (vulnerable dep) (OpenINF#144)
a01adcd 
Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is>
@renovate
build(deps-dev): bump typescript-eslint monorepo to v5.40.1 (OpenINF#146
c76287c 
)

Signed-off-by: Renovate Bot <bot@renovateapp.com>

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@dependabot
build(deps-dev): bump @types/node from 18.8.5 to 18.11.0 (OpenINF#145)
d10341a 
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 18.8.5 to 18.11.0.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@DerekNonGeneric
fix(src): map to return object .prototype undefined (OpenINF#147)
5ea6dda 
Co-authored-by: Restyled Commits <commits@restyled.io>

Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is>
Signed-off-by: Restyled Commits <commits@restyled.io>
@DerekNonGeneric
fix(auto): keep line feed and trailing blank lines
d8fe02e 
Refs: https://blog.jarrousse.org/2022/07/31/yaml-files-linting-and-formatting/
Refs: https://yaml.org/spec/1.2-old/spec.html#style/block/literal

Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is>
renovate bot and others added 4 commits October 19, 2022 23:02
@renovate
build(deps-dev): bump eslint-plugin-promise to v6.1.1 (OpenINF#152)
c5aaf7a 
Signed-off-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@dependabot
build(deps-dev): bump @types/node from 18.11.0 to 18.11.2 (OpenINF#151)
4eb564a 
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 18.11.0 to 18.11.2.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps-dev): bump @types/node from 18.11.2 to 18.11.3 (OpenINF#153)
f88397e 
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 18.11.2 to 18.11.3.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@renovate
build(deps-dev): bump eslint to v8.26.0 (OpenINF#154)
c1c9307 
Signed-off-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@DerekNonGeneric
Copy link
Member

@ignoreintuition, do you think you would be able to rebase this PR when you get the chance? It would be cool to see what CI is saying about it now. Let me know if you have any trouble (i think i can do it on my end as well).

@ignoreintuition
Copy link
Contributor Author

I rebased the file and added merged in my change. I am getting some errors in the workflows. Not sure if I did something wrong.

renovate bot and others added 6 commits October 24, 2022 23:56
@renovate
build(deps-dev): bump typescript-eslint monorepo to v5.41.0 (OpenINF#156
517aea7 
)

Signed-off-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
build(deps-dev): bump jasmine to v4.5.0 (OpenINF#160)
ee0850c 
Signed-off-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
build(deps-dev): bump typescript-eslint monorepo to v5.42.0 (OpenINF#162
55f31fd 
)

Signed-off-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@ignoreintuition @DerekNonGeneric
merged in isPlainObject
b57bfed
@ignoreintuition @DerekNonGeneric
merge conflicts
3731cf7
@ignoreintuition @DerekNonGeneric
bug fix on boolean
326d1b6
@DerekNonGeneric
Copy link
Member

Well, it's the last day of Hacktoberfest and I want you to get credit for this, but this commit should not be touching unrelated functions. Can you keep this focused on the one function?

@ignoreintuition
Copy link
Contributor Author

Unfortunately I am working late tonight. I'll try to look at this later this week.

DerekNonGeneric
DerekNonGeneric reviewed Nov 5, 2022
View reviewed changes
src/index.ts
): boolean {
if (o1 === null || o2 === null) {
): boolean => {
if (o1 == undefined || o2 == undefined) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (o1 == undefined || o2 == undefined) {
if (isNullish(o1) || isNullish(o2)) {

@DerekNonGeneric DerekNonGeneric mentioned this pull request Nov 5, 2022
Open
@DerekNonGeneric DerekNonGeneric linked an issue Nov 5, 2022 that may be closed by this pull request
[feature request] add new isPlainObject predicate function #32
Open
@DerekNonGeneric
Copy link
Member

well, we kinda pulled the source code out from under you now (not sure what to do about that)

maybe i will refactor this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DerekNonGeneric DerekNonGeneric DerekNonGeneric left review comments

Assignees

@ignoreintuition ignoreintuition

Labels
area: typescript enhancement javascript PRs that update JavaScript code wip Issues and PRs that are still a work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature request] add new isPlainObject predicate function
2 participants
@ignoreintuition @DerekNonGeneric